Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix borked index from refactor #7

Merged
merged 2 commits into from
Oct 19, 2023
Merged

fix borked index from refactor #7

merged 2 commits into from
Oct 19, 2023

Conversation

wadealexc
Copy link
Collaborator

  • TODO: needs a regression test, since this wasn't caught by existing tests.

This is more of a "we need to test churn works correctly," since after looking through tests it would appear we hardly test this at all.

ChaoticWalrus
ChaoticWalrus approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@ChaoticWalrus ChaoticWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChaoticWalrus ChaoticWalrus merged commit 7726551 into master Oct 19, 2023
1 check passed
@ChaoticWalrus ChaoticWalrus deleted the fix/deregister-operator branch October 19, 2023 17:28
@wadealexc wadealexc mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaoticWalrus ChaoticWalrus ChaoticWalrus approved these changes

@stevennevins stevennevins Awaiting requested review from stevennevins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wadealexc @ChaoticWalrus